On Thu, 15 May 2025 19:31:45 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Removing now-defunct COMPAT locale provider tests.
Nice cleanup; lgtm
test/jdk/sun/text/resources/LocaleDataTest.java line 178:
> 176: public class LocaleDataTest
> 177: {
> 178: static final String TEXT_RESOURCES_PACKAGE
> ="sun.text.resources.cldr";
Suggestion:
static final String TEXT_RESOURCES_PACKAGE = "sun.text.resources.cldr";
test/jdk/sun/text/resources/LocaleDataTest.java line 179:
> 177: {
> 178: static final String TEXT_RESOURCES_PACKAGE
> ="sun.text.resources.cldr";
> 179: static final String UTIL_RESOURCES_PACKAGE
> ="sun.util.resources.cldr";
Suggestion:
static final String UTIL_RESOURCES_PACKAGE = "sun.util.resources.cldr";
test/jdk/sun/text/resources/LocaleDataTest.java line 180:
> 178: static final String TEXT_RESOURCES_PACKAGE
> ="sun.text.resources.cldr";
> 179: static final String UTIL_RESOURCES_PACKAGE
> ="sun.util.resources.cldr";
> 180: static final String DEFAULT_DATAFILE ="LocaleData.cldr";
Suggestion:
static final String DEFAULT_DATAFILE = "LocaleData.cldr";
-------------
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/25257#pullrequestreview-2844921929
PR Review Comment: https://git.openjdk.org/jdk/pull/25257#discussion_r2091926227
PR Review Comment: https://git.openjdk.org/jdk/pull/25257#discussion_r2091926415
PR Review Comment: https://git.openjdk.org/jdk/pull/25257#discussion_r2091926586
