On Thu, 15 May 2025 16:42:48 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
> A consider class like this:
>
>
> public class TwoMains {
> private static void main(String... args) {}
> static void main() {
> System.out.println("Should be called, but is not.");
> }
> }
>
>
> The `MethodFinder` will do lookup for the `main(String[])` method, and it
> finds one, so does not proceed with a lookup for `main()`. But then, it will
> check the access modifier, and will reject that method, never going back to
> the `main()` method. This is not what the JLS says about the lookup - the
> private method is not a candidate, and should be ignored.
>
> Something similar happens if the return type is not `void`.
>
> This PR is fixing that by checking whether the `main(String[])` method is
> usable early, and falling back to `main()` if it `main(String[])` is not
> usable.
>
> It also removes the check for the `abstract` method, as that, by itself, is
> not really backed by JLS, but adds a check for `abstract` class, producing a
> user-friendly message is trying to invoke an instance `main` method on an
> `abstract` class (which, obviously, cannot be instantiated).
This pull request has now been integrated.
Changeset: 77a3e04f
Author: Jan Lahoda <jlah...@openjdk.org>
URL:
https://git.openjdk.org/jdk/commit/77a3e04ffc27554c14e3d45ba16ad0ee8f3c1eb1
Stats: 177 lines in 8 files changed: 151 ins; 10 del; 16 mod
8357016: Candidate main methods not computed properly
Reviewed-by: jpai, vromero
-------------
PR: https://git.openjdk.org/jdk/pull/25256
