On Mon, 19 May 2025 12:15:38 GMT, David Beaumont <[email protected]> wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a little refactoring to ensure that "read only" state was set
>> initially and only unset at the end of initialization if appropriate.
>>
>> By making 2 methods return values (rather than silently set non-final fields
>> as a side effect) it's now clear in what order fields are initialized and
>> which are final (sadly there are still non-final fields, but only a split of
>> this class into two types can fix that, since determining multi-jar support
>> requires reading the file system).
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed test.
src/jdk.zipfs/share/classes/module-info.java line 290:
> 288: * already exist, and is incompatible with {@code
> "create"=true}.
> 289: * Specifying both will cause an {@code
> IllegalArgumentException}
> 290: * to be thrown when the Zip filesystem is created
To be precise, perhaps this last sentence should be reworded to:
> Specifying {@code create} as {@code true} and {@code accessMode} as {@code
> readOnly} will cause an {@code IllegalArgumentException} to be thrown when
> the ZIP filesystem is created.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2095608509
