On Mon, 19 May 2025 12:15:38 GMT, David Beaumont <d...@openjdk.org> wrote:
>> Adding read-only support to ZipFileSystem. >> >> The new `accessMode` environment property allows for readOnly and readWrite >> values, and ensures that the requested mode is consistent with what's >> returned. >> >> This involved a little refactoring to ensure that "read only" state was set >> initially and only unset at the end of initialization if appropriate. >> >> By making 2 methods return values (rather than silently set non-final fields >> as a side effect) it's now clear in what order fields are initialized and >> which are final (sadly there are still non-final fields, but only a split of >> this class into two types can fix that, since determining multi-jar support >> requires reading the file system). > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed test. test/jdk/jdk/nio/zipfs/Utils.java line 48: > 46: * > 47: * @param name the file name of the jar file to create in the working > directory. > 48: * @param entries a list of JAR entries to be populated with random > bytes. Nit - maybe reword this to: > @param entries JAR file entry names, whose content will be populated with > random bytes. test/jdk/jdk/nio/zipfs/Utils.java line 78: > 76: * > 77: * @param name the file name of the jar file to create in the working > directory. > 78: * @param entries a map of relative file name path strings to file > content Nit - I think we should replace this description with something like: > @param entries a map of JAR file entry names to entry content ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2095686442 PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2095684096
