On Mon, 19 May 2025 15:18:12 GMT, David Beaumont <[email protected]> wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a little refactoring to ensure that "read only" state was set
>> initially and only unset at the end of initialization if appropriate.
>>
>> By making 2 methods return values (rather than silently set non-final fields
>> as a side effect) it's now clear in what order fields are initialized and
>> which are final (sadly there are still non-final fields, but only a split of
>> this class into two types can fix that, since determining multi-jar support
>> requires reading the file system).
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Don't use JUnit utils in TestNg.
src/jdk.zipfs/share/classes/module-info.java line 264:
> 262: * {@linkplain Runtime.Version Java SE Platform version
> number},
> 263: * an {@code IllegalArgumentException} will be thrown when
> the Zip
> 264: * filesystem is created.
I think this needs to "when creating the ZIP file system".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2096125703
