On Wed, 21 May 2025 11:55:16 GMT, Raffaello Giulietti <[email protected]>
wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Return first argument in case of tie (to be consistent with
>> BinaryOperator); junit tests
>
> test/jdk/java/util/Comparator/MinMaxTest.java line 39:
>
>> 37: public class MinMaxTest {
>> 38: @Test
>> 39: public void testMin() {
>
> According to
> [this](https://junit.org/junit5/docs/snapshot/user-guide/#writing-tests-classes-and-methods),
> test methods do not need to be `public` (but cannot be `private`).
>
> Suggestion:
>
> void testMin() {
Done, thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25297#discussion_r2101825796
