On Tue, 27 May 2025 16:23:47 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 17 additional commits since > the last revision: > > - Merge remote-tracking branch 'openjdk/master' into open > - Merge remote-tracking branch 'openjdk/master' into open > - Minor tweaks > - Assure >0 exit code and fix typos > - Validator to take a file, use term JAR file > - Mismatched order is considered invalid > - Adapt review feedback > - Address review feedback > - Adjust message based on review feedback > - Move all validation into EntryValidator, update the document > - ... and 7 more: https://git.openjdk.org/jdk/compare/c5449eae...2690e69f src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 239: > 237: /** > 238: * Validation per entry observed. > 239: * Each entry must appeare at least once in the CEN or LOC. Typo - should have been "appear" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2111620712