On Fri, 23 May 2025 18:44:42 GMT, Brian Burkhalter <[email protected]> wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: "input reader specific" -> "reader specific"
This looks good to me. I just have a question about the test, which I've added
inline as a review comment.
test/jdk/java/io/Reader/ReadAll.java line 54:
> 52: public class ReadAll {
> 53: private static final String PHRASE =
> 54: "Ange plein de gaieté, connaissez-vous l'angoisse";
Would it be useful to have this (or some other) phrase contain some newline
characters and also some whitespaces between a pair of newline characters? That
then can exercise the case where the input being read by a `Reader` would
consist of empty lines and lines with just whitespace characters. The way the
inputs lines are constructed in `setup()`, it's possible that even in current
form that scenario might get exercised but it's hard to be sure given the
`Random` nature of that content generation.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24728#pullrequestreview-2875329630
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2112052404
