On Mon, 26 May 2025 08:07:19 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> test/jdk/java/awt/font/TextLayout/RotFontBoundsTest.java line 63: >> >>> 61: >>> 62: private static final String INSTRUCTIONS = >>> 63: "A string \u201C" + TEXT + "\u201D is drawn at eight >>> different " >> >> I really don't like these tests being changed. It isn't part of the JDK >> build. >> People compile these in all sorts of locales. >> Please revert all the changes in the client tests. > > Just a clarification. What I did was convert curly quotes and an em dash to > normal ASCII quotes and an ASCII hyphen, just as it is in all other > `INSTRUCTIONS` in the tests. This is similar to what was done in JDK-8354273 > and JDK-8354213, and should have been made as part of those PRs if I only had > noticed this place by then. > > The user's locale should not really matter. When have stringent locale > requirements for building, and automatically setup the correct locale while > building. I don't think the locale will matter at runtime either, but it n > the rare case that it should matter, then pure ASCII would be prefer, > wouldn't it? > > Let me know if you still want me to revert it. I'd like this reverted. People *build* these tests in their local repos using javac and whatever their locale is. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25228#discussion_r2112728971
