On Mon, 2 Jun 2025 20:44:44 GMT, ExE Boss <d...@openjdk.org> wrote: >> Hannes Greule has updated the pull request incrementally with one additional >> commit since the last revision: >> >> make test failures easier to read > > src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java line 122: > >> 120: if (major < JAVA_1_VERSION || major > >> ClassFile.latestMajorVersion()) >> 121: // something not representable by CFFV, let's fall back >> 122: return ClassFileFormatVersion.latest(); > > For `major < JAVA_1_VERSION`, this should probably return > `ClassFileFormatVersion.RELEASE_0` instead.
I'm not sure if there is any better or worse default here, but for now, this just restores the semantics to what it was before javap was made CFFV-aware (instead of crashing). I think future improvements should be made separately. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25569#discussion_r2122784822
