On Wed, 21 May 2025 05:42:34 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - add description of BufferCleaner class
>> - exception handling in cleaner for backward consistency
>> - detabify
>
> src/java.base/share/classes/java/nio/BufferCleaner.java line 82:
>
>> 80: new Error("nio Cleaner terminated abnormally",
>> x).printStackTrace();
>> 81: }
>> 82: System.exit(1);
>
> This is the same behavior as jdk.internal.ref.Cleaner, for which this class is
> substituting in the new regime for DBB management. PR 22165 (and earlier
> versions of this PR) put this in the DBB's Deallocator::run method, but I
> think it's both clearer here, and better to leave the Deallocator as it was in
> mainline and be more consistent with the mainline code.
Also, I think the prior placement from PR22165 doesn't cover the unmapper
case, but only the DBB.Deallocator case, so (I think) was a hidden change from
the baseline use of jdk.internal.ref.Cleaner.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25289#discussion_r2125821039
