On Wed, 4 Jun 2025 17:39:55 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add pseudo-native entry for Reference.get0
>> - tidy CallGenerator lookup in Compile ctor
>
> src/hotspot/share/opto/compile.cpp line 786:
>
>> 784: initial_gvn()->set_type_bottom(s);
>> 785: verify_start(s);
>> 786: if (method()->intrinsic_id() == vmIntrinsics::_Reference_get) {
>
> Should we remove this now or as part of the redundant intrinsic cleanup for
> interpreter and c1? I see the interpreter is now kept intact.
I'm planning to remove the interpreter intrinsic as a followup. I couldn't
figure out how to hit this after making Reference::get0 the intrinsic.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24315#discussion_r2131561433
