On Thu, 5 Jun 2025 18:30:40 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Changes to generate CLDR resource bundles in UTF-8 encoding. The resource >> files in `java.base` are supposed to be US English only, but they also need >> to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye) > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > java.base/Gensrc.gmk comment Verified that 1. `TOOL_CLDRCONVERTER` points to `CLDRConverter` 2. `CLDRConverter` indeed accepts `-utf8` 3. `make/modules/java.base/Gensrc.gmk` and `make/modules/jdk.localedata/Gensrc.gmk` are the only two places where `CLDRConverter` is invoked make/modules/jdk.localedata/Gensrc.gmk line 49: > 47: -o $(GENSRC_DIR) \ > 48: -tzdatadir $(TZ_DATA_DIR) \ > 49: -utf8) @naotoj, I assume you did not add the comment to this change intentionally. ------------- Marked as reviewed by vyazici (Committer). PR Review: https://git.openjdk.org/jdk/pull/25648#pullrequestreview-2903974963 PR Review Comment: https://git.openjdk.org/jdk/pull/25648#discussion_r2131625005
