On Mon, 9 Jun 2025 22:57:24 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed the bundle
>
> src/java.base/share/classes/sun/util/resources/LocaleData.java line 214:
>
>> 212: int lastDot = baseName.lastIndexOf('.');
>> 213: String category = (lastDot >= 0) ?
>> baseName.substring(lastDot + 1) : baseName;
>> 214: if (adapter instanceof JRELocaleProviderAdapter jlpa) {
>
> For safety, should we have some type of failure if this is not true, similar
> to the previous `CCE`.
I think this is acceptable. If, for some reason, `adapter` is not an instance,
it will simply be ignored. That cast was a mere artifact from a time before we
had this `instanceof` construct and we knew it wouldn't throw a CCE.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25699#discussion_r2136674459
