On Wed, 11 Jun 2025 09:17:57 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> kabutz has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Removed sizes from LBD constructors - not necessary
>> - More optimizing volatile reads
>
> test/jdk/java/util/concurrent/tck/LinkedBlockingDequeTest.java line 1904:
>
>> 1902: fail("Expected InterruptedException in
>> putFirst()");
>> 1903: } catch (InterruptedException expected) {
>> 1904: // good that's what we want
>
> @kabutz I think it makes sense to verify that throwing the exception also
> clears the interrupt.
>
> Suggestion:
>
> // good that's what we want
> assertFalse(Thread.currentThread().isInterrupted());
Good idea, why not?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24925#discussion_r2139708615
