On Wed, 11 Jun 2025 11:41:41 GMT, David Beaumont <d...@openjdk.org> wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Extract shared function to compute current token
>
> test/jdk/tools/launcher/ArgFileSyntax.java line 177:
>
>> 175: },
>> 176: { // multiple args in one line and comments without preceding
>> whitespace
>> 177: { "-Xmx32m -XshowSettings#COMMENT 1",
>
> First case feels like a duplicate of the test at line 73. What's different?
> Maybe this case should just live next to that?
It only _feels_ so. Mind the gap(s) before the `#` number signs in the test at
line 73: they were and are still supported. This fix and test now ensures that
comments without gaps (read: whitespace) are supported.
> Maybe this case should just live next to that?
The location of the new test data is next to another "whitespace-related"
use-case. So, it's also related.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25589#discussion_r2139957273
