On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to german translations > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > line 49: > >> 47: .Principal.=\t主用户：\u0020 >> 48: .Public.Credential.=\t公共身份证明:\u0020 >> 49: .Private.Credential.=\t专用身份证明:\u0020 > > Why aren't the 2 lines above updated like in lines 46 and 47? I checked the ASCII codes here and on the source file. The updated colons are localized to full-width colons as @justin-curtis-lu mentioned in another thread here. I agree. I also believe lines 48 & 49 need to be updated to the same type of colon. I don't see a good reason for why this was not updated as well. We may need to file a bug with the translators to resolve this inconsistency for next time. We should update these lines here now unless anyone else sees a reason not to. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2165200706
