On Mon, 14 Jul 2025 09:11:08 GMT, Damon Fenacci <dfena...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Minimize the number of touched lines in `vmIntrinsics.hpp` >> - Remove Markdown-styling in comments >> - Improve wording of the `VerifyIntrinsicChecks` flag > > src/hotspot/cpu/x86/macroAssembler_x86.cpp line 6014: > >> 6012: } >> 6013: >> 6014: // Encode given `char[]`/`byte[]` to `byte[]` in ISO_8859_1 or ASCII > > Thanks for updating the comments! Do we need the markdown back quotes here > (and in other `macroAssembler-*` file comments)? No, we don't. Since Markdown has become ubiquitous in text-based typesetting, I find it easier to read and, whenever needed, share it in other mediums; Slack, GitHub, JIRA, Javadoc, Microsoft Office 365, Google Docs, etc. I presume you prefer without backticks – removed them in b60ff457. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25998#discussion_r2208477825
