On Wed, 16 Jul 2025 13:42:45 GMT, cagliostro92 <d...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/Properties.java line 78:
>>
>>> 76: * the call to the {@code propertyNames} or {@code list} method
>>> 77: * will fail if it is called on a "compromised" {@code Properties}
>>> 78: * object that contains a non-{@code String} key or value.
>>
>> Since `propertyNames` won't throw `CCE` with a non-String value, instead of
>> adding the "or value" wording here, we should move the `list` method to the
>> sentence above and remove it from the current sentence.
>>
>> E.g., on line 73
>>
>>> "If the {@code store}, {@code save}, or {@code list) method ...
>
> My bad, sorry. Fixed with 8d7e3d2fde65bd1e4ad85eca5ea93a430e2e8238
Thanks for the changes. The current form seems reasonable to me, although
others might have comments. I created the following CSR,
[JDK-8362447](https://bugs.openjdk.org/browse/JDK-8362447) for you. We will
need a reviewer to take a look at these changes as well. (Nit: we could use the
oxford comma in the class description changes.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25334#discussion_r2211098105
