On Tue, 8 Jul 2025 14:04:56 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588) >> >> This JEP proposes to enhance the HttpClient implementation to support HTTP/3. >> It adds a non-exposed / non-exported internal implementation of the QUIC >> protocol based on DatagramChannel and the SunJSSE SSLContext provider. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 550 commits: > > - merge latest changes from master branch > - http3: fix new HttpHeadersBuilder constructor > - qpack - optimize processing of decoder instruction exceptions > - http3/quic: update the code to use the newly introduced > jdk.internal.net.http.Origin > - Avoid speculating about the future in TODOs > - http3: rename PacketSpaceManager::isAcknowledging to > PacketSpaceManager::trackAcknowledgement > - merge latest changes from master branch > - http3: fix typo in UniStreamPair.java > - WriterQueue may leak before the constructor completes > - Limit the number of retries in H3UserInfoTest > - ... and 540 more: https://git.openjdk.org/jdk/compare/7b255b8a...f0a4fd3d src/java.net.http/share/classes/jdk/internal/net/http/AltSvcProcessor.java line 164: > 162: // serialized form of an origin (defined in section 6.2 of > RFC-6454) > 163: try { > 164: origin = > Origin.fromASCIISerializedForm(frame.getOrigin()); Do we check if the origin is authoritative before processing the alt service? I don't see that here src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 419: > 417: .thenApply((eimpl) -> {synchronized (Exchange.this) > {exchImpl = eimpl;} > 418: checkCancelled(); return eimpl; }) > 419: .thenApply(Function.identity()); Suggestion: .copy(); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2210059133 PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2209566030
