On Thu, 31 Jul 2025 12:40:48 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Convert non-visible markdown comments to JavaDoc for consistency.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 70:
>
>> 68: *
>> 69: * <p>While similar to {@code BasicImageReader}, this class is not a
>> conceptual
>> 70: * subtype of, it and deliberately hides types such as {@code
>> ImageLocation} to
>
> Hello David, is the comma here after "of" intentional? It reads a bit odd in
> the current form.
Ta, it should be "of it,", not "of, it".
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 172:
>
>> 170: requireOpen();
>> 171: if (!node.isResource()) {
>> 172: throw new IllegalStateException("Not a resource node: " +
>> node);
>
> Should this "public ByteBuffer getResourceBuffer(Node node)" throw
> `IllegalArgumentException` instead of `IllegalStateException` if the passed
> `node` isn't a resource node?
Hhm, good point. Most of the other cases are ISE, so maybe I got carried away.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2247994894
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2247997480
