On Tue, 5 Aug 2025 18:21:12 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

>> test/lib/jdk/test/lib/util/FileUtils.java line 457:
>> 
>>> 455:         // Create a directory junction or a symbolic link
>>> 456:         if (IS_WINDOWS) {
>>> 457:             if (!nativeLibLoaded) {
>> 
>> Suggestion: Since this logic to load the FileUtils library is now used 
>> twice, why not move it into a helper method which might also be synchronized 
>> (if tests are executed in parallel).
>
>> Since this logic to load the FileUtils library is now used twice, why not 
>> move it into a helper method
> 
> Sounds like a good idea. I'll investigate.

Done in ebd6f41.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26631#discussion_r2255635632

Reply via email to