On Sat, 2 Aug 2025 03:46:09 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> - Add `LauncherShortcut` and `LauncherShortcutStartupDirectory` types to the > model to define launcher shortcuts. For now > `LauncherShortcutStartupDirectory` enum has a single value. It will be > extended in [JDK-8308349](https://bugs.openjdk.org/browse/JDK-8308349) > enhancement. > - Replace `WinLauncherMixin.shortcuts()` with > `WinLauncherMixin.startMenuShortcut()` and > `WinLauncherMixin.desktopShortcut()`. > - Remove redundant `StandardBundlerParam.SHORTCUT_HINT` and > `StandardBundlerParam.MENU_HINT`; use "win-shortcut", "win-menu", and > "linux-shortcut" values instead of "shortcut" and "menu" to store launcher > shortcut configuration in the ".jpackage.xml" file. > - Add tests for launcher shortcut configuration in the ".jpackage.xml" file. Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26604#pullrequestreview-3099314206
