On Wed, 20 Aug 2025 21:25:33 GMT, Thomas Zimmermann <d...@openjdk.org> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   without copy digits, from @j3graham
>
> I'm not an official reviewer, but looks good to me 👍 
> 
> P.S.: While looking why you might have preferred `ISO_8859_1` over `US_ASCII` 
> (latin1 can skip the mapping of replacement characters because it defines the 
> entire byte range, correct?), I stumbled upon a reference to the removed 
> `SecurityManager` in [a 
> comment](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L652).

@zimmi, I created a simple issue for this outdated comment at 
https://bugs.openjdk.org/browse/JDK-8365887

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23311#issuecomment-3208202488

Reply via email to