On Wed, 20 Aug 2025 14:25:57 GMT, SendaoYan <s...@openjdk.org> wrote:
>> @sendaoYan this PR changes the default timeoutFactor and so also has to >> change quite a number of implicit and explicit timeouts. But that doesn't >> mean that test configs that already set their own timeoutFactor should >> adjust by the same factor! That just doesn't work for any test with an >> implicit default timeout. > > Yes, this PR change the default timeoutFactor when the tested JVM options do > not contains '-Xcomp', and at the same time also multiplies 4 of the timeout > value defined in some tests. > > So after this PR, the tests which the timeout value has been multiplied 4 > will have more timeout value, when the tested [JVM options contains > '-Xcomp'](https://github.com/lkorinth/jdk/blob/286a2cc6e989a1c7dcd641bce792c6411bc1d0ea/make/RunTests.gmk#L593). > > I do agree this change, what I mean is this change has some side effect. > >> If you would like to change it after the integration I think that would be >> valuable --- though my guess is that it could be quite a lot of work. > > I think I can try it in a new PR. I want to _warn_ you before you put too much energy into it. Changing the `-Xcomp` timeout factor might have even bigger impact than my change. Also, I have no idea how well that flag is tested in open testing. That is, your change might look good for you --- but might cause havoc for companies doing more extensive testing. I have still not received green light for integrating my change, because extensive testing is still being run (and other teams are evaluating). I advise against changing the flag. When I evaluate the benefit for the default timeout, it was mainly not the timeout _in itself_ that was the problem, but the fact that most people have no idea that the timeout factor is applied and thus can not create or debug tests in a good way. I hope this helps you, and does not come out as too negative. I just feel that I have put too much energy into this, and I do not hope that struggle for you. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2290422272
