On Mon, 25 Aug 2025 17:44:16 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Also, 'Otherwise' seems to refer to `If {@code value} is null` which I don't
>> think is the intent? Maybe you could add another list item (`<li>`) With:
>>
>>
>> If {@code dstType} is a primitive type and the runtime type of {@code value}
>> is <em>not</em> a primitive wrapper type, a {@link ClassCastException} is
>> thrown
>
> I use the same wording as `MethodHandles.explicitCastArguments` here. I
> recommend updating that method as well if you have such questions.
It would be nice if the term was more well define, especially for `char` and
`boolean`, but that doesn't have to be done in this patch.
I do think it would be good to split up the cases into separate list items
though. (I made it way too convoluted the first time around). Like I said in my
second comment, I don't think the current text works.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26714#discussion_r2301359452
