On Tue, 2 Sep 2025 16:20:57 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains nine commits: >> >> - Merge openjdk/master >> - Merge openjdk/master' into JDK-8359174 >> - Clean up module dependencies >> - Clean up jtreg directives >> - Adapt review feedbacks >> - Update copyright year >> - Update copyright year >> - cleanup >> - 8359174: tools/jlink/JLink20000Packages.java timed out > > test/jdk/tools/jlink/JLink20000Packages.java line 57: > >> 55: * jdk.jlink/jdk.tools.jimage >> 56: * @build tests.* >> 57: * @run main/othervm/timeout=1920 -Xlog:init=debug >> -XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal >> JLink20000Packages > > Hello Henry, I think we should remove this `timeout=1920`. It should no > longer be needed after your changes in this PR. That large value was recently > added when the default timeout factor was changed from 4 to 1 in mainline. ok, it was from the merge and I agree we can take away this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25981#discussion_r2316642423
