On Tue, 2 Sep 2025 20:35:50 GMT, Justin Lu <[email protected]> wrote: >> test/jdk/java/text/Format/DecimalFormat/DFSSerializationTest.java line 140: >> >>> 138: } >>> 139: >>> 140: // Previous versions of DFS could contain a null locale >> >> "Previous" suggests it would not allow null with this change, which is not >> the case. > > Instances created from the current standard _public_ API **do not allow** a > null locale, hence the clarification that previous versions **can contain** a > null locale. > > i.e. We do not expect to see null locales with up-to-date versions of DFS > that are not tampered with, so I think the comment is accurate.
I guess I mistook "previous" as previous implementation of DFS, but your comment refers to previous "stream" versions. Probably clarify it may help here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27008#discussion_r2317147454
