On Tue, 2 Sep 2025 10:50:33 GMT, Vanitha B P <d...@openjdk.org> wrote:

>> Problem Statements: 
>> 1. ZoneID is not updating when the user change the platform time zone 
>> setting, then click the "Update Time Zone" button.
>> 2. ZoneID was not displaying in the window as it is displaying in the lower 
>> releases.
>> 
>> Test Results:
>> jdk-25.0.1/bin/java -jar jtreg/lib/jtreg.jar -verbose:summary 
>> -testjdk:jdk-25.0.1  -dir:open/test/jdk 
>> java/util/TimeZone/DefaultTimeZoneTest.java
>> 
>> Passed: java/util/TimeZone/DefaultTimeZoneTest.java
>> Test results: passed: 1
>
> Vanitha B P has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   modified tzid variable

test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 111:

> 109:         panel.setLayout(new BoxLayout(panel, BoxLayout.PAGE_AXIS));
> 110:         // Time zone ID label
> 111:         var tzid = new JLabel("Time zone ID: " + 
> SDF.getTimeZone().getID(), SwingConstants.CENTER);

minor: do you think changing it to a more intuitive `timeZoneID` would make it 
easier to read? If you want to leave it as is - I don't mind

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27043#discussion_r2316292304

Reply via email to