> java.lang.invoke has a few Holder classes in DirectMethodHandle, 
> DelegatingMethodHandle, Invokers, and LambdaForm.
> 
> Currently, the comments simply refer to "Placeholder for xxx generated 
> ahead-of-time".
> 
> However, they carry executed bytecode and show up in flame graphs. The 
> current comments are definitely not sufficient for their details and purposes.
> 
> To address these shortcomings, I improved the comments on the Holder classes 
> and GenerateJLIClassesHelper to briefly describe the generation process. In 
> addition, I improved the comments on BoundMethodHandle to provide a more 
> efficient overview.

Chen Liang has updated the pull request incrementally with one additional 
commit since the last revision:

  More ioi review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27010/files
  - new: https://git.openjdk.org/jdk/pull/27010/files/d65a56a2..fa581ff3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27010&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27010&range=01-02

  Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/27010.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27010/head:pull/27010

PR: https://git.openjdk.org/jdk/pull/27010

Reply via email to