On Sat, 6 Sep 2025 20:44:55 GMT, Saint Wesonga <d...@openjdk.org> wrote:
> This test fails with errors like > >'=C:=,=ExitValue=3,PROCESSOR_ARCHITECTURE=ARM64,SystemRoot=C:\Windows,'< not > equal to '=C:=,=ExitValue=3,SystemRoot=C:\Windows,' > > The test does not expect the PROCESSOR_ARCHITECTURE variable to be returned > from the ProcessBuilder (called at > https://github.com/openjdk/jdk/blob/431f46724658b703e995e518cb7a2149c50d6a9d/test/jdk/java/lang/ProcessBuilder/Basic.java#L127 > for example). The fix is to treat it as an expected variable and strip it > out from the results, similar to how macOS and AIX strip out their expected > variables. > > The winEnvFilter method needs to be updated because some checks like > https://github.com/openjdk/jdk/blob/431f46724658b703e995e518cb7a2149c50d6a9d/test/jdk/java/lang/ProcessBuilder/Basic.java#L1694 > have the output on separate lines as opposed to the inline comma-separated > format where removeWindowsAArch64ExpectedVars is used. Look fine. I can't think but there might be a cleaner way to refactor the code, but this works and is similar to the existing adhoc fixups. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27131#pullrequestreview-3198132573
