On Thu, 11 Sep 2025 00:39:43 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
>> @AlanBateman @jianglizhou Now that Erik has approved the build >> functionality, I'd appreciate if anyone of you could approve as well, then I >> can finally integrate this. > >> @magicus I'll take a look today. > > Hi @magicus I looked at your changes and focused on the launcher changes. I > only looked quickly of the build changes, I think @erikj79's review is > sufficient. For launcher changes, my main question is Windows platform > support (for static JDK) and testing. The rest of the comments are minor. > I just realized that the testing I kicked off (tier1-5 on our internal CI) > does not include running tests using the static-jdk. @jianglizhou Do you have > any recommendation to the easiest way to use the static-jdk for testing? We enabled running jtreg tests on static-jdk in GHA (https://github.com/openjdk/jdk/commit/16d45511342c32ac8e8f72fb68dc21ce13339dbe). It sets `JDK_UNDER_TEST=<static-jdk-path>`, `JDK_FOR_COMPILE=<regular-jdk-path>` and `extra-problem-lists` with .github/workflows/test.yml to run tests on static-jdk. Probably relatively easy to setup with tired testing as well. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24380#issuecomment-3283164409
