On Sat, 13 Sep 2025 09:35:54 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which addresses the issue noted in >> https://bugs.openjdk.org/browse/JDK-8367597? >> >> As noted in that issue, on certain occasions, during shutdown of the JVM, >> the logging in `Runtime.exit()` generates a `NullPointerException`. The >> issue is due to the JVM not being fully initialized when (concurrently) the >> signal handler thread calls the `Runtime.exit()` code which then attempts to >> log a message. >> >> The commit in this PR skips the logging from `Runtime.exit()` if the JVM >> isn't fully initialized at that point in time. I've manually verified that >> this change indeed addresses the issue by running the same tests on the >> hosts where this was previously failing. No new regressions tests have been >> introduced given the nature of the issue. >> >> tier1 testing with this change completed without any related issues and >> additional tier testing is currently in progress. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > move the check to Shutdown.exit() Looks good to me. Thanks ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27270#pullrequestreview-3224659923
