On Tue, 16 Sep 2025 16:10:44 GMT, Pavel Rappo <[email protected]> wrote:
>> Please review this documentation-only change, which I believe does **NOT**
>> require CSR.
>>
>> The change touches java.time.** classes that I happen to have been using a
>> lot recently. While the diff is pretty self-describing, here's the summary
>> of what I did:
>>
>> * used a comma separator for some big integer values, to improve readability;
>> * fixed a few typos and grammar.
>>
>> While I'm open to discuss the change, I also have some questions. Note: I'm
>> not attempting to address those questions in this PR.
>>
>> * What's the significance of the second argument in
>> Duration.between(Temporal, Temporal) being exclusive? For example, would the
>> result of the following call be different if the second argument was
>> inclusive?
>>
>> Duration.between(Instant.ofEpochSecond(1), Instant.ofEpochSecond(2))
>>
>> Are there any cases here where that distinction matters?
>>
>> * In many cases, the following phrase is used throughout documentation:
>>
>> > positive or negative
>>
>> While the intent is clearly to stress the directed nature of values,
>> shouldn't we -- for completeness -- also mention zero where applicable?
>>
>> * What's the significance of title-case for Java Time-Scale? FWIW, the
>> documentation also uses "Java time-scale".
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> A few more typos
src/java.base/share/classes/java/time/temporal/ChronoField.java line 602:
> 600: * This is usually a fixed number of hours and minutes.
> 601: * It is equivalent to the {@link ZoneOffset#getTotalSeconds() total
> amount} of the offset in seconds.
> 602: * For example, during the winter Paris has an offset of {@code
> +01:00}, which is 3,600 seconds.
Suggestion:
* For example, during the winter, Paris has an offset of {@code +01:00},
which is 3,600 seconds.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27296#discussion_r2353070935
