On Fri, 19 Sep 2025 00:27:04 GMT, Chen Liang <[email protected]> wrote:
>> The Signature modeling in the ClassFile API is missing some validations >> required by JVMS, notably identifier character restrictions and void type >> restrictions. In addition, the model currently uses `ClassDesc` to indicate >> a simple name for an inner class signature, which is incorrect, and this >> patch proposes to deprecate that API for removal. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Fix links src/java.base/share/classes/jdk/internal/classfile/impl/ClassRemapperImpl.java line 312: > 310: Signature.ClassTypeSig.of( > 311: > cts.outerType().map(this::mapSignature).orElse(null), > 312: Util.toInternalName(map(cts.classDesc())), // > wrong, needs fix with InnerClasses Signatures of inner classes should be disambiguated to avoid this kind of confusions. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27380#discussion_r2362022365
