On Sat, 18 Oct 2025 00:20:30 GMT, Alexander Matveev <[email protected]>
wrote:
>> - Make jpackage tests output more stable.
>> - Make jpackage output more stable.
>> - Add more action to the script derandomizing jpackage test logs.
>
> test/jdk/tools/jpackage/clean_test_output.sh line 105:
>
>> 103: -e 's|taskkill /F /PID [0-9]\{1,\}|taskkill /F /PID <pid>|'
>> 104:
>> 105: # Convert PID value in `The process with PID 5640 has been
>> terminated`
>
> I am confused with this comment. Should we use something more generic then
> 5640. Same below for 57182ms.
It is just a line from the log used as a comment to give a clue what the sed
expression is doing. It will replace the sequence of any digits with `<pid>`
token, not just "5640".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27870#discussion_r2441487154
