On Thu, 9 Oct 2025 16:12:48 GMT, Alexey Semenyuk <[email protected]> wrote:
>> - Validate "libjli.dylib" file in the "lib" directory referenced with the >> `--runtime-image` option. >> - Split "ERR_MissingJLinkOptMacAppStore" error key into >> "error.invalid-runtime-image-bin-dir" and >> "error.invalid-runtime-image-bin-dir.advice"; moved new keys to mac-specific >> string property file. >> - Fix a couple of typos in RuntimeBuilderBuilder and WixSourceConverter >> classes. >> >> Error messages: >> >> Runtime image "ErrorTest/test.85b994e1/empty-runtime-image" is missing >> "lib/**/libjli.dylib" file >> >> Runtime image "ErrorTest/test.05a7421a/invalid-runtime-bundle" is missing >> "Contents/Home/lib/**/libjli.dylib" file >> >> Runtime image "/Users/alexeysemenyuk/jpackage-dev-runtime" should not >> contain "bin" folder >> Advice to fix: Use --strip-native-commands jlink option when generating >> runtime image used with --mac-app-store option > > Alexey Semenyuk has updated the pull request incrementally with two > additional commits since the last revision: > > - ErrorTest: better coverage > - MacFromParams: Restore missing imports Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27701#pullrequestreview-3321053815
