On Mon, 29 Sep 2025 19:41:52 GMT, Volkan Yazici <[email protected]> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   RemoveFields(duration) and filter internal frames
>
> test/jdk/java/lang/reflect/Field/mutateFinals/modules/Driver.java line 30:
> 
>> 28:  *     field is open to m2 and not open to m3.
>> 29:  * @build m1/* m2/* m3/*
>> 30:  * @run junit/othervm --illegal-final-field-mutation=allow 
>> -DallowedToMutate=m1,m2 m1/p1.TestMain
> 
> Instead of an explicit `allow`, shall we use (and hence, stress) the defaults?
> 
> Suggestion:
> 
>  * @run junit/othervm -DallowedToMutate=m1,m2 m1/p1.TestMain

The default will allow or deny and these cases are tested.  However, you are 
right that it wouldn't do any harm to have it run without options.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25115#discussion_r2390873380

Reply via email to