On Tue, 23 Sep 2025 16:56:37 GMT, Naoto Sato <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Swap other args in assertions in LocaleMatchingTest
>
> test/jdk/java/util/Locale/LocaleMatchingTest.java line 349:
>
>> 347: assertNotEquals(lr1, lr4, " LR(ja, 1.0).equals(LR(en, 1.0))
>> should return false.");
>> 348: assertNotNull(lr1, " LR(ja, 1.0).equals(null) should return
>> false.");
>> 349: assertNotEquals("", lr1, " LR(ja, 1.0).equals(\"\") should
>> return false.");
>
> Nit: If we change the unexpected and actual, probably do the same for L346/347
I had originally left L345-347 untouched because it seemed like one of those
cases where there wasn't a clear expected/unexpected (compared to the `""` in
L349). But you are right that it would be consistent and no reason to not do so
considering the opposite _actual_ vs _expected_ positioning of TestNG vs JUnit.
Fixed in
https://github.com/openjdk/jdk/pull/27441/commits/aef3447704fabe43348dfe2fdfd4d1731515571b.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27441#discussion_r2373123586
