On Tue, 7 Oct 2025 23:19:28 GMT, Justin Lu <[email protected]> wrote:

> Please review this PR which corrects a rounding error for DecimalFormat on 
> tie cases when the maximum fraction digits allowed is one less than the 
> position of the first significant digit in the double rounded. For example, 
> rounding a value such as 0.0005 to a maximum of 3 fractional digits. In order 
> to get the correct `count` value, we must strip the trailing zeros prior to 
> the check to ensure we have the correct value of `count` = 1 so that we can 
> go down the _Rounding position is the last index_ case which properly checks 
> if the String double was already rounded or is exact from its true decimal 
> form.

LGTM

-------------

PR Review: https://git.openjdk.org/jdk/pull/27681#pullrequestreview-3315869483

Reply via email to