On Fri, 17 Oct 2025 20:18:24 GMT, Valerie Peng <[email protected]> wrote:
>> I did make changes based on your code to eliminate len and updates to >> variable names. > > Yes, I take a second look and maybe a smaller adjustments would work as well. > E.g, > 1) nit: method name `invGenRoundKeys` -> `genInvRoundKeys` > 2) make this method static by passing `sessionKey[0]` and `rounds` as > arguments, > 3) no need for `len` since it's always `WB` > 4) for the intermediate buffer of 4 words, can we not use `w` as this name is > used in both the spec and genRoundKeys method as "Word array for the key > schedule". It'd help people understand the code better if we adopt the same > naming convention in "Algorithm 5 Pseudocode for KEYEXPANSIONEIC()", e.g. > `temp` for the intermediate buffer and `dw` for the final result. Sorry, missed this comment in the melee. Re: 1) method name, agreed; 2) to static, agreed; 3) remove len, prior commit; 4) variable name alignment, agreed. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2442722654
