On Wed, 22 Oct 2025 16:53:30 GMT, Jaikiran Pai <[email protected]> wrote:
>> src/java.base/share/classes/java/util/UUID.java line 208:
>>
>>> 206: * @since 26
>>> 207: * */
>>> 208: public static UUID epochMillis(long timestamp) {
>>
>> Now that we have settled on which API to expose, would it be better to
>> rename this new method to `fromEpochMillis(...)`? This class already has a
>> `fromString(...)` API, so `fromEpochMillis(...)` would fit in with that
>> style and would be a bit more precise too, I think.
>
> The rest of the changes in the PR looks fine to me. Before reviewing the CSR,
> I think we should come to an agreement on the method naming.
>
> I prefer `fromEpochMillis(...)` instead of the current `epochMillis(...)`.
> @RogerRiggs, @AlanBateman which one of these method names do you suggest we
> proceed with?
Not to thrash on the name but `fromEpochMillis(millis))` is a good name similar
to `fromString(String)`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25303#discussion_r2453392447
