On Tue, 11 Nov 2025 09:41:43 GMT, Severin Gehwolf <[email protected]> wrote:
>> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refactoring to clarify version checking cases > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 620: > >> 618: // silently ignore and fall through to version mismatch >> 619: targetRelease = "missing"; >> 620: } > > Instead of claiming that the `release.txt` file contains the string > "missing", we could just throw a specific exception to that effect, no? > Something along the lines of: > > > Error: java.base module specified on the module path does not contain > critical resource needed for verifying compatibility to the current runtime > with version <currrent-version> Sure we can. I do want to keep a message consistent and softer as this can happen to releases before this get merged. Thought 'missing' is a little better than 'N/A' which is more likely in a release.txt. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2514962713
