On Wed, 12 Nov 2025 14:55:02 GMT, Lance Andersen <[email protected]> wrote:
>> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment to test > > test/jdk/tools/jar/ValidatorTest.java line 315: > >> 313: /** >> 314: * Validates that the LOC MANIFEST.MF entries are at the expected >> positions. >> 315: * > > Thank you for adding a comment. I might suggest adding a little more clarity > or point to JarInputStream docs as the Manifest Location for JarFile is not > an issue. > > The issue boils down to the fact that JarInputStream walks the LOC > sequentially and because of this there is the limitation on the location of > where the Manifest can live. > > Not a big deal overall and I will leave it to you. It is just no obvious to > someone who is working in this area the 1st time as this issue is not > directly related to the Zip specification, but is a JarInputStream limitation Addressed both, better error messages and the test comment in https://github.com/openjdk/jdk/pull/28154/commits/99e8e3200beac1fea0d32df10d457416773283f3 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28154#discussion_r2522351147
