On Fri, 14 Nov 2025 01:16:31 GMT, Alexander Matveev <[email protected]>
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> MainResources.properties: remove unreferenced L10N key
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/cli/StandardOption.java
> line 335:
>
>> 333:
>> 334: public static final OptionValue<Boolean> MAC_APP_STORE =
>> booleanOption("mac-app-store")
>> 335: //.scope(MAC_SIGNING) // TODO: --mac-app-store should be
>> applicable to app image signing operation because it redefines signing key
>
> I do not like any TODO comments. They usually never got fixed. Bug needs to
> be filed if follow up is required.
Filed https://bugs.openjdk.org/browse/JDK-8371924
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28163#discussion_r2528571171
