On Sat, 15 Nov 2025 04:50:20 GMT, Jaikiran Pai <[email protected]> wrote:
> The changes look good to me but I think Hannes' question is valid. > > > > What does `testFinalizeMethodCallsSuperFinalize` test now? > > > > > > I have verified java/util/concurrent/tck/JSR166TestCase.java#default > > locally, test still run passed. Test > > java/util/concurrent/tck/JSR166TestCase.java#default will invoke all the > > junit tests in java/util/concurrent/tck directory. > > Is the testFinalizeMethodCallsSuperFinalize() needed or can it be removed? > With the changes in this PR, I don't see what this method tests, especially > given its name. It's a different matter that even without the changes to this > PR, I am not sure what was being tested/asserted in that test method. Sorry, I get the questions now. Test testFinalizeMethodCallsSuperFinalize was added by [JDK-8190324](https://bugs.openjdk.org/browse/JDK-8190324). Since https://github.com/openjdk/jdk/pull/28278 will remove the (empty) ThreadPoolExecutor.finalize() method, so testFinalizeMethodCallsSuperFinalize can be removed also. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28278#issuecomment-3539852107
