On Wed, 19 Nov 2025 17:47:07 GMT, Severin Gehwolf <[email protected]> wrote:
> Please review this simple fix to `jlink`'s `--release-info` plugin to handle > non-ASCII in vendor strings. The JDK build uses UTF-8 encoding for the > produced `release` file that is being passed to `jlink` at build-time via the > `--release-info` plugin. However, the plugin internally uses > `java.util.Properties.load(InputStream)` API which assumes `ISO-8859-1` > encoding of the input stream. The proposed fix is to use the > `java.util.Prorperties.load(Reader)` API instead and pass it an > `InputStreamReader` with `UTF-8` encoding. > > Testing: > - [x] GHA > - [x] `test/jdk/tools/jlink` tests including the new reg-test which fails > prior and passes after the fix. > > Thoughts? Hello Severin, would it better to (even) specify the expectations of the `--release-info` jlink plugin and what encoding it expects for the file content? I might be wrong, but even with the use of `UTF-8` for reading the given file (like proposed in this PR), it may not guarantee that it is the right Charset to use for that file. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28399#issuecomment-3556940180
