On Fri, 21 Nov 2025 09:40:06 GMT, Jaikiran Pai <[email protected]> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove extra line.
>> - Align behavior of compression levels to the input received and sync
>> help+documentation messages.
>
> test/jdk/tools/jlink/TaskHelperTest.java line 246:
>
>> 244: new CompressTestCase(new String[] {"--compress=zip-7"},
>> "zip-7", false),
>> 245: new CompressTestCase(new String[] {"--compress=zip-8"},
>> "zip-8", false),
>> 246: new CompressTestCase(new String[] {"--compress=zip-9"},
>> "zip-9", false)
>
> I think a few negative tests would also be useful. For example, `-c 3`
> `--compress=42`, `--compress=zip-` should all fail.
Thank you for pointing out that part. I pushed a new commit to cover suggested
values and more (I followed the previous example on testing for invalid values
😁).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2549284063
