> JDK-8260555 exposed > test/jdk/java/text/Format/NumberFormat/NumberRoundTrip.java as being > susceptible to timeouts. > While the timeout factor is reverted, this test was testing too many inputs, > and should be changed. > Originally, it was testing (~1000 locales * 4 factories) against ~30 numeric > inputs. The test does not need to be exhaustive to this degree. > > The total amount of locales is changed to sample around a 1/4 of those > provided by the provider. The numeric inputs are reduced to about ~20. (The > fixed ones remain, and the random ones are cut in half.) > > Locally, I observe average execution for this test to be about ~1.3 seconds, > compared to ~3.4 seconds previously. The PR also does a drive-by clean up of > the test, i.e. getting rid of the unnecessary escaping + string > manipulation/printing and separating the test inputs from the actual testing > work done.
Justin Lu has updated the pull request incrementally with one additional commit since the last revision: terminology correction ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28443/files - new: https://git.openjdk.org/jdk/pull/28443/files/dca988e7..271dfc78 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28443&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28443&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/28443.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28443/head:pull/28443 PR: https://git.openjdk.org/jdk/pull/28443
