On Thu, 20 Nov 2025 15:24:21 GMT, Severin Gehwolf <[email protected]> wrote:
>> Please review this simple fix to `jlink`'s `--release-info` plugin to handle >> non-ASCII in vendor strings. The JDK build uses UTF-8 encoding for the >> produced `release` file that is being passed to `jlink` at build-time via >> the `--release-info` plugin. However, the plugin internally uses >> `java.util.Properties.load(InputStream)` API which assumes `ISO-8859-1` >> encoding of the input stream. The proposed fix is to use the >> `java.util.Prorperties.load(Reader)` API instead and pass it an >> `InputStreamReader` with `UTF-8` encoding. >> >> Testing: >> - [x] GHA >> - [x] `test/jdk/tools/jlink` tests including the new reg-test which fails >> prior and passes after the fix. >> >> Thoughts? > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Copyright updates. Any more input on this one? I'd appreciate a review. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/28399#issuecomment-3569801799
